Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Froce browser tab to close as part of wrapup? #3

Closed
homerhanumat opened this issue Jan 22, 2016 · 6 comments
Closed

Froce browser tab to close as part of wrapup? #3

homerhanumat opened this issue Jan 22, 2016 · 6 comments

Comments

@homerhanumat
Copy link
Owner

Raised by @rpruim: in response to input$done, can we arrange that the browser tab closes?

@rpruim
Copy link

rpruim commented Jan 22, 2016

I don't know whether this is possible, but there seems to be no reason to keep the dead tab open since it doesn't do anything anymore and can't be refreshed either.

@homerhanumat
Copy link
Owner Author

I am looking into a bit of javascript that should do the trick.

On Fri, Jan 22, 2016 at 11:08 AM, Randall Pruim notifications@github.com
wrote:

I don't know whether this is possible, but there seems to be no reason to
keep the dead tab open since it doesn't do anything anymore and can't be
refreshed either.


Reply to this email directly or view it on GitHub
#3 (comment)
.

@homerhanumat
Copy link
Owner Author

This is out of our reach for the moment:

rstudio#3

@homerhanumat
Copy link
Owner Author

There seems not to be an ideal solution. To get the window to close upon Done, it has to open in a Pane Viewer or Dialog Viewer. Pane Viewer is much too small, of ocurse. But even thought the Dialog Viewer has width and height arguments, it can't go over a certain size. The app really needs the entire computer screen, as in a browser that the user has maximized, and here we cannot close windows on the user.

@rpruim
Copy link

rpruim commented Jan 23, 2016

Is it at least possible to open the window/tab with a target so that it gets reused rather than spawning a new tab each time the addin is used? (Apologies if it does this already.)

@homerhanumat
Copy link
Owner Author

Any locally-run shiny app does the same thing: if you open it up into a browser window, you have to close the window yourself. The next app you run will just open a new window. In the thread referenced above, JJ Allaire and Joe Cheng might be talking about a way around this, but I quite follow what they are saying.

@homerhanumat homerhanumat changed the title Froce browser tab to close as part of wraup? Froce browser tab to close as part of wrapup? Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants