Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$signal: value / interval #8

Closed
jalmeroth opened this issue Oct 14, 2016 · 11 comments
Closed

$signal: value / interval #8

jalmeroth opened this issue Oct 14, 2016 · 11 comments

Comments

@jalmeroth
Copy link
Contributor

Shouldn't the $signal be treated same as the $uptime in v2?

Therefore I propose:
$signal/value
$signal/interval

@marvinroger
Copy link
Member

You are right. I did not even think about that.

@marvinroger
Copy link
Member

Done 😃

@jamesmyatt
Copy link

jamesmyatt commented Oct 24, 2016

Is it necessary to have separate $uptime/interval and $signal/interval topics? Would it be simpler to combine them and use the same value for both $uptime and $signal?

Would probably make implementation simpler too since the one function can update both at the same time.

@marvinroger
Copy link
Member

What would be the name of the interval topic?

@marvinroger
Copy link
Member

Something like:

  • $dynamic/signal: 100
  • $dynamic/uptime: 3612
  • $dynamic/interval: 60

?

@jamesmyatt
Copy link

yes, although I think I prefer something like $statistics

@marvinroger
Copy link
Member

These are not really statistics, IMO. Let's wait for other users inputs. 😉

@euphi
Copy link
Member

euphi commented Oct 24, 2016

I think it is some kind of statistics, so $statistics or $stats would be fine.

Other proposals:

  • $health
  • $device

I prefer $stats.

@marvinroger
Copy link
Member

Oh? My bad! For me, statistics are the the discipline of working with numbers, but I guess that's because I'm still a student 😅
$stats sounds like the right thing to do, then!

@marvinroger
Copy link
Member

2e28318 is it fine?

@jalmeroth
Copy link
Contributor Author

Works for me. 👍 Thank you!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants