Escape the lookup url during reverse image search (#3905)

honestbleeps · Jan 19, 2017 · 73efb5c · 73efb5c
1 parent 1511d3e
commit 73efb5c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/modules/showImages.js b/lib/modules/showImages.js
@@ -46,6 +46,7 @@ import {
 	frameThrottle,
 	nextFrame,
 	isPageType,
+	string,
 	waitForEvent,
 	watchForElement,
 	getPercentageVisibleYAxis,
@@ -1522,7 +1523,8 @@ function setMediaControls(media, lookupUrl, downloadUrl) {
 				// Google doesn't like image url's without a protacol
 				lookupUrl = new URL(downcast(lookupUrl, 'string'), location.href).href;
 
-				openNewTab(`https://images.google.com/searchbyimage?image_url=${lookupUrl}`);
+				// Escape query string parameters
+				openNewTab(string.encode`https://images.google.com/searchbyimage?image_url=${lookupUrl}`);
 				break;
 			case 'showImageSettings':
 				SettingsNavigation.loadSettingsPage(module.moduleID, 'mediaControls');