Skip to content

Commit

Permalink
fix for tracking history in private browsing mode in opera.
Browse files Browse the repository at this point in the history
the line about safari will never execute for now, because Safari doesn't allow localStorage use in private browsing, which RES relies on.  For now, RES / Safari's private browsing are not friends.
  • Loading branch information
honestbleeps committed Apr 3, 2013
1 parent 9b661da commit a61dd86
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
11 changes: 11 additions & 0 deletions Opera/index.html
Expand Up @@ -288,6 +288,17 @@
break;
}
break;
case 'addURLToHistory':
var thisWin = opera.extension.windows.getLastFocused();
var priv = thisWin.private;
var passBack = {
msgType: 'addURLToHistory',
data: {
url: request.url,
isPrivate: priv }
}
event.source.postMessage(passBack);
break;
default:
var passBack = {
msgType: '',
Expand Down
16 changes: 16 additions & 0 deletions lib/reddit_enhancement_suite.user.js
Expand Up @@ -496,6 +496,12 @@ function operaMessageHandler(msgEvent) {
waitForRESStorage(savedEventData);
}
break;
case 'addURLToHistory':
var url = eventData.url;
if (! eventData.isPrivate) {
modules['showImages'].imageTrackFrame.contentWindow.location.replace(url);
}
break;
default:
// console.log('unknown event type in operaMessageHandler');
break;
Expand Down Expand Up @@ -9936,6 +9942,16 @@ modules['showImages'] = {
}
self.postMessage(thisJSON);
modules['showImages'].imageTrackShift();
} else if (BrowserDetect.isOpera()) {
var thisJSON = {
requestType: 'addURLToHistory',
url: url
}
opera.extension.postMessage(JSON.stringify(thisJSON));
} else if (BrowserDetect.isSafari()) {
if (!safari.application.privateBrowsing.enabled) {
modules['showImages'].imageTrackFrame.contentWindow.location.replace(url);
}
} else if (typeof(modules['showImages'].imageTrackFrame.contentWindow) != 'undefined') {
modules['showImages'].imageTrackFrame.contentWindow.location.replace(url);
} else {
Expand Down

0 comments on commit a61dd86

Please sign in to comment.