Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbarfix no longer works #960

Closed
honestbleeps opened this issue Apr 19, 2014 · 0 comments
Closed

toolbarfix no longer works #960

honestbleeps opened this issue Apr 19, 2014 · 0 comments

Comments

@honestbleeps
Copy link
Owner

http://www.reddit.com/r/RESissues/comments/23dufo/bug_toolbarfix_no_longer_works/

this is a hairy one. for two reasons.

  1. element.removeAttribute('onmousedown') no longer stops the event from firing. I'm not sure if this is chrome specific or what...

  2. now that Reddit Gold members get stored history, the reddit folks are also calling save_href($(this)) in onmousedown - which we actually don't want to destroy...

possible solution:

Look at how I ended up having to fix turboSelfText - it was the same problem... I ended up having to clone the node and replace it so that event listeners would go away... we would then want to add back the save_href call - but since we can't access reddit's javascript, we'd need to replace it with our own API call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant