Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] No Participation module #1187

Merged
merged 45 commits into from
Jun 15, 2014
Merged

Conversation

jewel-andraia
Copy link
Collaborator

  • Heavily encourage "don't vote or comment because you were linked in NP mode" via notifications. (enabled by default)
    • On loading a np.reddit.com url, show a notification: Don't participate; brigading is bad mmkay?
    • On voting on an np.reddit.com url, show a notification: Don't vote; brigading is bad
    • On composing a comment on an np.reddit.com url, show a notification: Don't comment; brigading
    • On visiting any np.reddit.com which isn't a subreddit/multireddit post listing or comments page, show a notification: You can participate now, click here to return to regular reddit
  • Add various options to block/undo voting/commenting (disabled by default)
    • hide vote buttons (only if no vote already)
    • undo voting automatically (same)
    • disable comment textarea
    • enable NP mode even subreddit swhere you're a subscriber

Concession for subscribers -- you're probably a community member already, so NP mode doesn't apply to you.

screen shot 2014-06-09 at 12 34 26 am

I strongly think this should go into RES v4.4 because RES now works on np.reddit.com.

Fixes #579

warn "don't participate" when on a np.reddit.com page; and again when attempting to vote or when starting to write comment
optionally (default enabled) revert votes while on np.reddit.com

warn "you can leave NP now" on pages which aren't post listings, besides frontpage and user profile
@jewel-andraia
Copy link
Collaborator Author

<Walter_Bishop> also check for np-XX.reddit.com or XX-np.reddit.com (XX is sometimes nm for nightmode styling)

@jewel-andraia jewel-andraia added this to the v4.4 milestone Jun 5, 2014
@jewel-andraia jewel-andraia self-assigned this Jun 6, 2014
@@ -55,6 +55,7 @@ window.addEventListener('DOMContentLoaded', function() {
'modules/commentPreview.js',
'modules/commentTools.js',
'modules/context.js',
'modules/noParticipation.js',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be placed here if you want to keep the alphabetically order.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops. well, order doesn't realllllly matter.

@jewel-andraia
Copy link
Collaborator Author

wondering if hideVoteButtons makes undoVoteAutomatically obsolete..

@jewel-andraia
Copy link
Collaborator Author

@hermithome i think you mentioned you had ideas for better wording on description/notification? including clarifying that "yes, your votes and comments do count, np.reddit.com is not some magical happy place where you can fart around without thinking"?

@matheod
Copy link
Collaborator

matheod commented Jun 9, 2014

I think you should make only one option about vote : something like disableVote which will prevent voting by clicking or with keyboard when enabled. Because yes, hideVOteButtons and undoVOteAutomatically looks duplicate, but it must prevent vote by clicking and by keyboard.

@matheod
Copy link
Collaborator

matheod commented Jun 9, 2014

Well, there's already the notification when you start typing the comment.
Hum, I don't remember any other notification exept the one when we load the page. I might be wrong, I don't have time to re test for the moment.

@jewel-andraia
Copy link
Collaborator Author

hideVoteButtons handles both clicking and keyboard voting. if keyboard vote, the "don't vote" notification is also shown.

@matheod
Copy link
Collaborator

matheod commented Jun 9, 2014

Then you should change the name :)

@jewel-andraia
Copy link
Collaborator Author

hmm "blockAndHideVoteButtons" ?

@matheod
Copy link
Collaborator

matheod commented Jun 9, 2014

why not just disableVoteButtons ?

@jewel-andraia
Copy link
Collaborator Author

i guess that works. i balked initially because under the hood the buttons aren't getting disabled attribute set, but then I remembered this is user-facing documentatoin.

@hermithome
Copy link
Contributor

First draft on NP wiki text:

NP or "no participation" is a way to help enforce reddit's rules and etiquette on voting. It is against site rules to engage in vote manipulation or brigading.

Vote brigading is what happens when a group of people get together to upvote or downvote the same thing--be it a person, a comment or a group of people representing a dissenting ideology. That doesn't mean you can't link to a post or comment elsewhere on reddit. In fact, there are subreddits which exist solely to link to comments and posts in other subreddits, such as meta subs like /r/ShitRedditSays and /r/SubRedditDrama and promotion subs like /r/BestOf. However, when you post or follow links like this, it's important to respect site rules and reddiquette and avoid voting or commenting. NP mode helps you do that.

NP links (np.reddit.com instead of www.reddit.com) helps users and mods prevent vote brigading. Many subreddits use custom subreddit styling (CSS) to disable voting on NP links. Reddit Enhancement Suite also provides warnings not to vote or comment when in NP mode. You can also adjust RES settings to disable voting and commenting entirely when in NP mode, to protect you from accidentally participating.

If you do click on an NP link and want to comment, please learn about the community first. Respect that you are an outsider coming into an established community. Many communities offer an introduction, and have rules and guidelines. Read these before attempting to participate.  

If you frequently follow links and vote, or if you frequently post links without using the np prefix, you may find yourself banned or shadowbanned by moderators or the admins. The admins are the last line of defense, so please use NP links to help enforce good behaviour.

@jewel-andraia
Copy link
Collaborator Author

what the heck, let's just say it's good enough and sort out the moral quandaries later -- it's as easy as disabling the module by default.

jewel-andraia added a commit that referenced this pull request Jun 15, 2014
[WIP] No Participation module
@jewel-andraia jewel-andraia merged commit b1ab613 into honestbleeps:master Jun 15, 2014
@jewel-andraia jewel-andraia mentioned this pull request Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants