-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] No Participation module #1187
Conversation
warn "don't participate" when on a np.reddit.com page; and again when attempting to vote or when starting to write comment optionally (default enabled) revert votes while on np.reddit.com warn "you can leave NP now" on pages which aren't post listings, besides frontpage and user profile
<Walter_Bishop> also check for np-XX.reddit.com or XX-np.reddit.com (XX is sometimes nm for nightmode styling) |
keyboardNav triggers np's click handler
logged out inherently means no participation
…d; revertVote disabled by default
@@ -55,6 +55,7 @@ window.addEventListener('DOMContentLoaded', function() { | |||
'modules/commentPreview.js', | |||
'modules/commentTools.js', | |||
'modules/context.js', | |||
'modules/noParticipation.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be placed here if you want to keep the alphabetically order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops. well, order doesn't realllllly matter.
in case of module showing notification as an advisory (but thing not actually voted on)
… enabled instead of standard "don't vote" notification
wondering if hideVoteButtons makes undoVoteAutomatically obsolete.. |
@hermithome i think you mentioned you had ideas for better wording on description/notification? including clarifying that "yes, your votes and comments do count, np.reddit.com is not some magical happy place where you can fart around without thinking"? |
I think you should make only one option about vote : something like disableVote which will prevent voting by clicking or with keyboard when enabled. Because yes, hideVOteButtons and undoVOteAutomatically looks duplicate, but it must prevent vote by clicking and by keyboard. |
|
hideVoteButtons handles both clicking and keyboard voting. if keyboard vote, the "don't vote" notification is also shown. |
Then you should change the name :) |
hmm "blockAndHideVoteButtons" ? |
why not just disableVoteButtons ? |
i guess that works. i balked initially because under the hood the buttons aren't getting disabled attribute set, but then I remembered this is user-facing documentatoin. |
First draft on NP wiki text: NP or "no participation" is a way to help enforce reddit's rules and etiquette on voting. It is against site rules to engage in vote manipulation or brigading. Vote brigading is what happens when a group of people get together to upvote or downvote the same thing--be it a person, a comment or a group of people representing a dissenting ideology. That doesn't mean you can't link to a post or comment elsewhere on reddit. In fact, there are subreddits which exist solely to link to comments and posts in other subreddits, such as meta subs like /r/ShitRedditSays and /r/SubRedditDrama and promotion subs like /r/BestOf. However, when you post or follow links like this, it's important to respect site rules and reddiquette and avoid voting or commenting. NP mode helps you do that. NP links (np.reddit.com instead of www.reddit.com) helps users and mods prevent vote brigading. Many subreddits use custom subreddit styling (CSS) to disable voting on NP links. Reddit Enhancement Suite also provides warnings not to vote or comment when in NP mode. You can also adjust RES settings to disable voting and commenting entirely when in NP mode, to protect you from accidentally participating. If you do click on an NP link and want to comment, please learn about the community first. Respect that you are an outsider coming into an established community. Many communities offer an introduction, and have rules and guidelines. Read these before attempting to participate. If you frequently follow links and vote, or if you frequently post links without using the np prefix, you may find yourself banned or shadowbanned by moderators or the admins. The admins are the last line of defense, so please use NP links to help enforce good behaviour. |
rewriting NP warnings and description
…nIfSubscriber enabled
Conflicts: Chrome/manifest.json OperaBlink/manifest.json RES.safariextension/Info.plist XPI/lib/main.js
what the heck, let's just say it's good enough and sort out the moral quandaries later -- it's as easy as disabling the module by default. |
[WIP] No Participation module
Concession for subscribers -- you're probably a community member already, so NP mode doesn't apply to you.
I strongly think this should go into RES v4.4 because RES now works on np.reddit.com.
Fixes #579