Simple score coloration type for comments #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from upstream
Pull from upstream
| @@ -72,7 +72,7 @@ | |||
| <ul id="RESKnownFeatureRequests"><li style="color: red;">Loading...</li></ul> | |||
| </li> | |||
| </ol> | |||
| <span id="submittingFeature" class="submittingToEnhancementButton">I still want to submit a feature request!<span> | |||
| <span id="submittingFeature" class="submittingToEnhancementButton">I still want to submit a feature request!</span> | |||
|
kinda do want a more descriptive name, like "Classic" or "Orangered/Periwinkle" |
jewel-andraia
added a commit
that referenced
this pull request
Oct 4, 2014
Simple score coloration type for comments
jewel-andraia
added a commit
that referenced
this pull request
Oct 4, 2014
follow-up to #1660. i'm open to other suggestions
|
kinda arbitrarily went with "reddit classic". now accepting other suggestions |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1304 and #1375.
Has provisions for future presets, just add a new option and preset colors.
I'm not sure if it should have a more descriptive name than simple coloration.
Also closed a random unclosed element and removed a few unnecessary commas.