Firefox: show alert when db cannot be created #3199
Conversation
| } | ||
|
|
||
| addListener('storage', ([operation, key, value], worker) => { | ||
| if (!db) storageFailureAlert(worker); |
There was a problem hiding this comment.
Note: three or four storage requests are made before init crashes, so this will open multiple alerts in series.
But I don't think that's a problem because you'd immediately roll back/disable the extension if this happens (memoizing by worker and current URL would be mildly complex for little gain).
So background pages can display alerts (usually catastrophic errors).
erikdesjardins
force-pushed
the
firefox-no-storage-alert
branch
from
49a23b2
to
6931e36
Compare
|
I wonder if we could have RES automatically report this somewhere. It'd be nice to have some hard data on how common this is. |
|
Redditors can be, ahem "security-conscious" (which is why we have zero telemetry), so probably not. We might have opt-in telemetry in the future, but that's a fairly large project. Hopefully this won't be a problem for very long though, what with the planned stabilization of WebExtensions in Firefox 48, where hopefully their implementation of |
This should give us an idea if #3194 is common or not (in the beta); hopefully we don't have to fall back to simple-storage and its horrible instability 馃槹.