New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate updates css #3858
Integrate updates css #3858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erik or I can help with the body class options and migrations. Can you double check the placement of hide tag line?
@@ -1382,3 +1382,19 @@ | |||
} | |||
} | |||
} | |||
|
|||
|
|||
.res-nightmode:not(.res-nightMode-coloredLinks){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does nightmode options include a colored links boolean body class option yet? Should probably be enabled by default.
@@ -43,6 +43,9 @@ | |||
|
|||
body.res-console-open { | |||
overflow: hidden; | |||
&.front-page.res-hide-tagline-frontpage .tagline { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a merge conflict resolution issue here, this probably shouldn't be inside the console open block.
@@ -3,6 +3,10 @@ | |||
color: orangered; | |||
} | |||
|
|||
.new-comment .usertext-body { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it should move inside a "new comments count" block.
@@ -115,6 +115,10 @@ | |||
#NREPause { | |||
cursor: pointer; | |||
|
|||
.res-neverEndingReddit-hideFloatingPauseButton & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should become a disabled boolean body class option, with a migration to enable it if found in a stylesheet module's option body class value, and filter out the row containing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*there should be added
Merged code: http://pastebin.com/1793xxTZ
it was used to prevent scrollbars from appearing on new comments in nightmode, but they no longer appear without it (fixed somewhere else)
73df8f5
to
950eea8
Compare
(most of this was already included)
8153d35
to
a61adfc
Compare
Thanks! (so the build passed but it's marked as errored...hmmm) |
Some of the css refers to features that needs to be implemented.