Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate updates css #3858

Merged
merged 7 commits into from Jan 21, 2017

Conversation

roshkins
Copy link
Contributor

@roshkins roshkins commented Jan 8, 2017

Some of the css refers to features that needs to be implemented.

Copy link
Collaborator

@jewel-andraia jewel-andraia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erik or I can help with the body class options and migrations. Can you double check the placement of hide tag line?

@@ -1382,3 +1382,19 @@
}
}
}


.res-nightmode:not(.res-nightMode-coloredLinks){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does nightmode options include a colored links boolean body class option yet? Should probably be enabled by default.

@@ -43,6 +43,9 @@

body.res-console-open {
overflow: hidden;
&.front-page.res-hide-tagline-frontpage .tagline {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a merge conflict resolution issue here, this probably shouldn't be inside the console open block.

@@ -3,6 +3,10 @@
color: orangered;
}

.new-comment .usertext-body {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should move inside a "new comments count" block.

@@ -115,6 +115,10 @@
#NREPause {
cursor: pointer;

.res-neverEndingReddit-hideFloatingPauseButton & {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should become a disabled boolean body class option, with a migration to enable it if found in a stylesheet module's option body class value, and filter out the row containing it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*there should be added

@erikdesjardins erikdesjardins modified the milestone: v5.3.x (v5.4.0) Jan 9, 2017
@erikdesjardins erikdesjardins self-assigned this Jan 11, 2017
roshkins and others added 2 commits January 20, 2017 20:11
it was used to prevent scrollbars from appearing on new comments in nightmode, but they no longer appear without it (fixed somewhere else)
@erikdesjardins erikdesjardins changed the title [WIP] Integrate updates css Integrate updates css Jan 21, 2017
@erikdesjardins erikdesjardins merged commit f8685ec into honestbleeps:master Jan 21, 2017
@erikdesjardins
Copy link
Collaborator

Thanks!

(so the build passed but it's marked as errored...hmmm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants