Contain subreddit list scrolling #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the |
|
Thanks for sharing this, by the way. This property looks like a great solution for scrollable overlays I'm working on in other projects. |
|
Whoops, I missed that sass-lint didn't like that property. Looks like sass-lint does not yet have a release containing the property but it's in the develop branch sasstools/sass-lint@ba8887e. I've added an exemption to |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the user scrolls to the bottom of the subreddit list the whole page scrolls down, this moves this subreddit list up causing some confusion.
overscroll-behavioris a new property to deal with this, it's supported in chrome as of 63 (the current stable release) and will be available in firefox come version 59