Add Github Expando Host #5299
Open
Add Github Expando Host #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new GitHub open graph embeds to create an expando host for linked github repositories.
Example below taken from from https://old.reddit.com/domain/github.com/
Currently the host will ignore github.com/user/ routes as there's nothing built in to show (Unless someone wanted to use the GH public API data to build a profile for these from scratch).
I've tested this next to the now renamed
github-gistembed and it appears to function correctly (Matching the gist.github to the gist expando and the direct github ones to this. I have additionally added a secondary hostname check to ensure it can't accidentally fall through).Very open to any feedback as been quite a while since I played with the hosts/RES code in general.
Relevant issue: N/A (I can raise on is useful)
Tested in browser: Chrome