New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a `dogecointip` module a la `bitcointip` #826

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mathphreak

mathphreak commented Mar 10, 2014

Most of the work was just s/bit/doge/.

Not everything that bitcointip has is applicable here, mostly because the bitcointip bot has an API that dogetipbot doesn't. Also, some of the stuff that works in bitcointip doesn't work here for some reason:

  • Automatically hiding bot verifications doesn't work for some weird reason, even though it's the same exact code bitcointip uses.
  • Address detection doesn't work either for some reason, although it looks like the only point of that was finding the deposit address.
Add a `dogecointip` module a la `bitcointip`
Automatically hiding bot verifications doesn't work for some weird
reason, even though it's the same exact code `bitcointip` uses.

Address detection doesn't work either for some reason, although it looks
like the only point of that was finding the deposit address.
@honestbleeps

This comment has been minimized.

Owner

honestbleeps commented Mar 10, 2014

I appreciate the contribution! I do want to hold off on merging though, because /u/skeeto who already created the bitcointip module may help out by working to incorporate dogetipbot into his... I would prefer from a cleanliness/organization standpoint that we not have multiple modules, though I'll leave this open for now until we have a concrete decision...

@mathphreak

This comment has been minimized.

mathphreak commented Mar 10, 2014

Sounds good!

@honestbleeps

This comment has been minimized.

@mc10

This comment has been minimized.

Collaborator

mc10 commented Aug 29, 2014

Going to close this in lieu of a (to be made) more broad fix to #868.

@mc10 mc10 closed this Aug 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment