Add a dogecointip module a la bitcointip
#826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically hiding bot verifications doesn't work for some weird reason, even though it's the same exact code `bitcointip` uses. Address detection doesn't work either for some reason, although it looks like the only point of that was finding the deposit address.
|
I appreciate the contribution! I do want to hold off on merging though, because /u/skeeto who already created the bitcointip module may help out by working to incorporate dogetipbot into his... I would prefer from a cleanliness/organization standpoint that we not have multiple modules, though I'll leave this open for now until we have a concrete decision... |
|
Sounds good! |
|
Sorry, here's a reference to the thread: |
|
Going to close this in lieu of a (to be made) more broad fix to #868. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the work was just
s/bit/doge/.Not everything that
bitcointiphas is applicable here, mostly because thebitcointipbot has an API thatdogetipbotdoesn't. Also, some of the stuff that works inbitcointipdoesn't work here for some reason:bitcointipuses.