Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a code formatter #1112

Open
BethanyBerkowitz opened this issue Jun 27, 2023 · 2 comments
Open

Use a code formatter #1112

BethanyBerkowitz opened this issue Jun 27, 2023 · 2 comments

Comments

@BethanyBerkowitz
Copy link
Contributor

Using Prettier would help us have code that's... prettier. By enforcing a standard, it would also remove the annoying whitespace changes that we often see popping up in PRs just because two different developers have slightly different settings in their text editors or IDEs.

There are other formatters out there, but Prettier is the most popular and most people are familiar with it. I also like that it's opinionated so we don't need to have a lot of back-and-forth on config options.

@subzero10
Copy link
Member

I was hoping that we would achieve the desired formatting styles just by using eslint, but it seems that it's not true 🤷.

@BethanyBerkowitz
Copy link
Contributor Author

I was hoping that we would achieve the desired formatting styles just by using eslint, but it seems that it's not true 🤷.

The existing eslint setup is definitely really helpful! But yeah, formatters and linters are good at different things, so it's pretty common to have both. I don't think this is an urgent problem for us, though. It would become more urgent if we regularly had a larger group of people pushing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants