Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Honebadger.notify() void #1162

Open
subzero10 opened this issue Aug 11, 2023 · 0 comments
Open

Make Honebadger.notify() void #1162

subzero10 opened this issue Aug 11, 2023 · 0 comments
Labels
js @honeybadger-io/js

Comments

@subzero10
Copy link
Member

subzero10 commented Aug 11, 2023

With the introduction of async beforeNotify handlers, the return value of Honeybadger.notify() is not always consistent (you can follow discussion here at #984). To sum up:

  • when async beforeNotify handlers exist, the return value of Honeybadger.notify() is always true
  • when beforeNotify handlers are all synchronous, the return value indicates whether or not the error will be reported to Honeybadger

With this issue, we can make Honeybadger.notify() return void, knowing that one can know whether the error will be reported to Honeybadger with an afterNotify handler: if the callback is called with an err, it means that the error was not sent to Honeybadger.

Note: This should be a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
js @honeybadger-io/js
Projects
None yet
Development

No branches or pull requests

1 participant