Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept notification options for grouping #74

Closed
Kaname87 opened this issue Feb 16, 2019 · 9 comments
Closed

Accept notification options for grouping #74

Kaname87 opened this issue Feb 16, 2019 · 9 comments
Assignees

Comments

@Kaname87
Copy link

Kaname87 commented Feb 16, 2019

Honeybadger is accepting grouping options for easier error tracing.
https://docs.honeybadger.io/lib/javascript/guides/customizing-error-grouping.html#grouping-by-component

I think that would be nicer if we can pass such options via honeybadger-php also.

@Kaname87
Copy link
Author

I've tried to address this feature request by my self in #75
But not sure if this implementation seems ok.
I'm willing to close or re-write PR if i can get some feedback. Thanks.

@sixlive sixlive self-assigned this Feb 16, 2019
@sixlive
Copy link
Collaborator

sixlive commented Feb 16, 2019

Thanks for your contribution!!

I'll take a look at this over the weekend.

@sixlive
Copy link
Collaborator

sixlive commented Feb 19, 2019

It was my birthday over the weekend and this totally slipped my mind. Taking a look through things now.

@Kaname87
Copy link
Author

No problem. please take your time. Happy birthday :)

@sixlive
Copy link
Collaborator

sixlive commented Feb 20, 2019

Haha thanks! I'm playing with your PR and a few other implementation ideas.

@Kaname87
Copy link
Author

that sounds grate :) then i can just close and wait your implementation. or it's ok to me that I try implementing your idea.

@sixlive
Copy link
Collaborator

sixlive commented Feb 22, 2019

I'm thinking of a similar approach. I'll see how close they are and make some comments on the PR.

@sixlive
Copy link
Collaborator

sixlive commented Jul 15, 2019

This will land in 1.6

@sixlive sixlive closed this as completed Jul 15, 2019
@sixlive
Copy link
Collaborator

sixlive commented Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants