Accept grouping options for notification #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rather than do some review here I opened a PR with come updates to your repo/branch. |
Accept grouping for notification
|
@sixlive sorry i merged your pr but does your 'wip" commit comment mean you were still about to change or refactor something ? if so i can revert the change and can remove merged commit log also if needed. |
|
It was ready for you to merge, I forgot to squash and rewrite before opening. I see one more change that I need to make though. I just want to verify in the HB UI and we should be good to go. I’ll update tonight. |
sixlive
requested changes
Feb 26, 2019
| public static function get($array, $key, $default = null) | ||
| { | ||
| if (! static::accessible($array)) { | ||
| return value($default); |
There was a problem hiding this comment.
Suggested change
| return value($default); | |
| return $default; |
|
I did an e2e test and it looks like its reporting as expected!
|
|
Closing in favor of #85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Partially resolves 74
In this PR just only making
componentandactionacceptable among the notification options.fingerprintis also grouping options but that is not a part ofrequestbut a part oferrorso not included in this change.Related PRs
na
Todos
Steps to Test or Reproduce