Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uneeded dependency #165

Merged
merged 4 commits into from Sep 8, 2022
Merged

Remove uneeded dependency #165

merged 4 commits into from Sep 8, 2022

Conversation

shalvah
Copy link
Contributor

@shalvah shalvah commented Sep 8, 2022

Closes #164

@shalvah
Copy link
Contributor Author

shalvah commented Sep 8, 2022

@subzero10 not sure if you do PHP, but this is a very easy one to review. 😅

subzero10
subzero10 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@subzero10 subzero10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do, but only the last few years!
I'm surprised we don't have a composer.lock file for dependencies. Is there any reason for that?

@shalvah
Copy link
Contributor Author

shalvah commented Sep 8, 2022

I'm not the one who set up this repo, but there's no strong reason AFAIK. You can either leave it or commit it. Packages in the PHP ecosystem aren't as fragile as in npm, so having locked dependencies on packages doesn't give many benefits.

@shalvah shalvah merged commit 6ac7bc5 into master Sep 8, 2022
@shalvah shalvah deleted the remove-uneeded-dependency branch August 4, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subzero10 subzero10 subzero10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spatie/regex dependency
2 participants
@shalvah @subzero10