Add php 73 support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Looks like the 73 builds are failing for some reason. |
|
Yeah, downstream dependency isn’t setup to support 7.3. I’m likely going to remove the dependency tonight. This PR is mostly to add 7.3 to CI, the package works fine on 7.3 without dev dependencies. |
This was referenced Dec 11, 2018
Merged
sixlive
force-pushed
the
add-php-73-support
branch
from
341bae5
to
95b5346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Adds PHP 7.3 to the Travis build matrix and removes unnecessary over specification of php versions in the composer manifest.
Related PRs
n/a
Todos
Steps to Test or Reproduce
Check CI process of PR