Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoneyBadger raises NoMethodError when request.env has symbol keys #215

Closed
derekprior opened this issue Feb 9, 2017 · 2 comments
Closed

Comments

@derekprior
Copy link

See: https://github.com/honeybadger-io/honeybadger-ruby/blob/master/lib/honeybadger/util/request_hash.rb#L65

If request.env contains symbol keys, you will get:

NoMethodError:
       undefined method `start_with?' for :foo:Symbol

Seems like this should be to_s.start_with? at minimum as you may use any object as a hash key in Ruby but most objects should respond meaningfully enough to to_s for this purpose.

@joshuap
Copy link
Member

joshuap commented Feb 10, 2017

@derekprior thanks for the issue report -- I'll have a bugfix release out today!

joshuap pushed a commit that referenced this issue Feb 10, 2017
@joshuap
Copy link
Member

joshuap commented Feb 10, 2017

The fix for this has been released in 3.0.1

@joshuap joshuap closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants