Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bundling unnecessary dependencies in published gem #514

Closed
rdokov opened this issue Dec 18, 2023 · 3 comments · Fixed by #515 or #516
Closed

Avoid bundling unnecessary dependencies in published gem #514

rdokov opened this issue Dec 18, 2023 · 3 comments · Fixed by #515 or #516
Labels

Comments

@rdokov
Copy link

rdokov commented Dec 18, 2023

The new github actions release process seems to include a lot of vendored gems that don't seem necessary. Comparing the sizes of different gem versions I'm getting the following:
v5.2.1 ~220kB download and unpacks to ~920kB
v5.3.0 ~2.1MB download and unpacks to ~14MB

It seems the reason is that the newer version includes 60 different packages under vendor/ while the older version has just 2. I suspect you either need to omit the bundler cache in the release action or alternatively explicitly specify which gems to vendor in the gemspec instead of using a wildcard.

@subzero10
Copy link
Member

Hey @rdokov, thank you for flagging this. I will take a look and come back to you.

@subzero10
Copy link
Member

Hey @rdokov, this should be resolved with v5.4.1!

@rdokov
Copy link
Author

rdokov commented Dec 22, 2023

Yes, the latest version looks good. Thank you for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants