Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveJob premature reporting #534

Closed
cristi opened this issue Mar 23, 2024 · 2 comments · Fixed by #535
Closed

ActiveJob premature reporting #534

cristi opened this issue Mar 23, 2024 · 2 comments · Fixed by #535
Assignees

Comments

@cristi
Copy link

cristi commented Mar 23, 2024

I'm using solid-queue with the ActiveJob retry_on option for exceptions triggered by flaky APIs. Is there a way to have honeybadger report the exceptions only after the attempts are exhausted to cut down on unnecessary noise?

looking at the source code it seems other plugin/adapters have an attempt_threshold config option, but there isn't one for ActiveJob. Or am I missing something and can ActiveJob be leveraged for this?

thanks

@stympy
Copy link
Member

stympy commented Mar 23, 2024

I just released v5.8.0, which adds the active_job.attempt_threshold configuration option.

@cristi
Copy link
Author

cristi commented Mar 23, 2024

I just released v5.8.0, which adds the active_job.attempt_threshold configuration option.

this is amazing, thank you so much. I'll test it and let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants