Ensure fastify instrumentation honors the httpParserHook config #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test for this case to both fastify and express instrumentations
robbkidd
changed the title
robbkidd
added
type: bug
robbkidd
reviewed
Jan 21, 2021
| @@ -72,7 +72,7 @@ const instrumentFastify = function (fastify, opts = {}) { | |||
| // start our trace handling | |||
|
|
|||
| // parse incoming trace headers into a span context | |||
| let spanContext = traceUtil.getTraceContext(traceIdSource, request); | |||
| let spanContext = traceUtil.parseTraceHeader(traceIdSource, request); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastify instrumentation was using
traceUtils.getTraceContextwhich does not usehttpTraceParserHookconfiguration.