Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop auto-detecting x-request-id and amazon trace headers #445

Merged
merged 1 commit into from Sep 21, 2021

Conversation

vreynolds
Copy link
Contributor

  • breaking change
  • users will have to opt-in to custom trace propagation
  • no more missing root spans for users with uninstrumented amazon load balancers

Initial PR that intended to make this change
Docs update for the missing root spans that result from auto-detection

- breaking change
- users will have to opt-in to custom trace propagation
- no more missing root spans for users with uninstrumented amazon load balancers
@vreynolds vreynolds added version: bump major A PR that breaks backwards compatibility. type: discussion Requests for comments, discussions about possible enhancements. labels Sep 10, 2021
@vreynolds vreynolds removed the type: discussion Requests for comments, discussions about possible enhancements. label Sep 21, 2021
@vreynolds vreynolds marked this pull request as ready for review September 21, 2021 19:25
@vreynolds vreynolds requested a review from a team as a code owner September 21, 2021 19:25
@vreynolds vreynolds merged commit 8d7f41d into main Sep 21, 2021
@vreynolds vreynolds deleted the vera.less-header-autodetect branch September 21, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: bump major A PR that breaks backwards compatibility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants