Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] developing with a local version of libhoney in the beeline's example application #616

Merged
merged 2 commits into from Sep 27, 2022

Conversation

emilyashley
Copy link
Contributor

@emilyashley emilyashley commented Sep 15, 2022

Which problem is this PR solving?

  • When developing changes for beeline and libhoney concurrently, I wanted to run both at the same time locally in my development environment (rather than relying on published versions of libhoney). This provides documentation on how I did that :)

Short description of the changes

  • reduce complexity of npm script in example app
  • add documentation for local development

@emilyashley emilyashley marked this pull request as ready for review September 15, 2022 22:13
@emilyashley emilyashley requested a review from a team as a code owner September 15, 2022 22:13
@emilyashley emilyashley self-assigned this Sep 15, 2022
@emilyashley emilyashley added version: no bump A PR with maintenance or doc changes that aren't included in a release. type: documentation labels Sep 15, 2022
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Works on my machine, which in this case is the point.

Works for me!

I added the suggestion for changing directory in a subshell with (cd ../.. && … ) below, but also I found that npm run setup had me still in the examples/node-tracing/ directory when it completed. Including the parens doesn't appear to change the behavior, but would only prevent people like me from suggesting seems-like-a-good-idea subshell parens in the future. 😁

examples/node-tracing/package.json Outdated Show resolved Hide resolved
@emilyashley emilyashley merged commit 43ffe13 into main Sep 27, 2022
@emilyashley emilyashley deleted the emash-beeline-libhoney-dev-docs branch September 27, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants