Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about requiring http #655

Merged
merged 1 commit into from Dec 21, 2022
Merged

docs: add note about requiring http #655

merged 1 commit into from Dec 21, 2022

Conversation

JamieDanielson
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • This PR just adds a note to the README regarding a potential issue some users may run into. It is sometimes necessary for auto-instrumentation to manually add require('https'); before requiring in an http request library.

@JamieDanielson JamieDanielson requested a review from a team as a code owner December 21, 2022 21:31
@JamieDanielson JamieDanielson self-assigned this Dec 21, 2022
@JamieDanielson JamieDanielson added version: no bump A PR with maintenance or doc changes that aren't included in a release. type: documentation no-changelog Omit this PR from changelog/release notes. labels Dec 21, 2022
vreynolds
vreynolds approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@JamieDanielson JamieDanielson merged commit a85daba into main Dec 21, 2022
@JamieDanielson JamieDanielson deleted the jamie.note-require-http branch December 21, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vreynolds vreynolds vreynolds approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
no-changelog Omit this PR from changelog/release notes. type: documentation version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stealthy-require breaks things
2 participants
@JamieDanielson @vreynolds