Skip to content

Commit

Permalink
maint: Don't deploy kprobes for now (#106)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
We're not currently using the data that comes out of kprobes so we
should disable for now.

## Short description of the changes
- Don't call `generate` as part of the `build` makefile target
- Don't setup probes during main.go setup

## How to verify that this has the expected result
No change - we're not using data from the kprobes now.
  • Loading branch information
MikeGoldsmith committed Aug 22, 2023
1 parent 6261fea commit 150806c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ docker-generate:
docker run --rm -v $(shell pwd):/src hny/ebpf-agent-builder

.PHONY: build
build: generate
build:
CGO_ENABLED=1 GOOS=linux go build -o hny-ebpf-agent main.go

.PHONY: docker-build
Expand Down
6 changes: 0 additions & 6 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"time"

"github.com/honeycombio/ebpf-agent/assemblers"
"github.com/honeycombio/ebpf-agent/bpf/probes"
"github.com/honeycombio/ebpf-agent/utils"
"github.com/honeycombio/libhoney-go"
"github.com/rs/zerolog"
Expand Down Expand Up @@ -92,11 +91,6 @@ func main() {
cachedK8sClient := utils.NewCachedK8sClient(k8sClient)
cachedK8sClient.Start(ctx)

// setup probes
p := probes.New(cachedK8sClient)
go p.Start()
defer p.Stop()

agentConfig := assemblers.NewConfig()

// setup TCP stream reader
Expand Down

0 comments on commit 150806c

Please sign in to comment.