wrong value for agent_version with latest tag #192
Labels
type: bug
Something isn't working
Comments
This was referenced Sep 18, 2023
JamieDanielson
added a commit
that referenced
this issue
Sep 18, 2023
## Which problem is this PR solving? - Reverts #186 - Reverts #187 ## Short description of the changes As seen in #192 (and attempted to fix in #201), GitHub Actions checkout action doesn't include git tag history, so computing current version from tags doesn't work at the moment. We are temporarily reverting this to expedite a new release using hardcoded version values, and will revisit this later. ## How to verify that this has the expected result `honeycomb.agent_version` shows the `vX.Y.Z` version in use, in agent container logs and telemetry. --------- Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
|
Fixed in #206. We'd still like to compute build version from git tags, but GitHub's action/checkout used in the PR and Release workflows does not pull all tags by default. We'll need to tinker more with the workflows and the action configuration to get the CI build environment to know about our tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Versions
v0.0.15-alpha
Steps to reproduce
Additional context
The text was updated successfully, but these errors were encountered: