fix: Revert 186 and 187 for injecting version during build #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
approved these changes
Sep 18, 2023
JamieDanielson
deleted the
revert-186-robb.inject-version-during-build
branch
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
As seen in #192 (and attempted to fix in #201), GitHub Actions checkout action doesn't include git tag history, so computing current version from tags doesn't work at the moment.
We are temporarily reverting this to expedite a new release using hardcoded version values, and will revisit this later.
How to verify that this has the expected result
honeycomb.agent_versionshows thevX.Y.Zversion in use, in agent container logs and telemetry.