fix: Update TCP connection timeout to 30 seconds #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to mike/cached-k8s # Conflicts: # main.go
- also sets “event sent” log to debug instead of info
Co-authored-by: Purvi Kanal <kanal.purvi@gmail.com>
MikeGoldsmith
changed the title
…to mike/stream-goroutine-creeping
MikeGoldsmith
changed the title
MikeGoldsmith
changed the title
JamieDanielson
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Old TCP stream were not being closed correctly. This was because the timeout was set to 24 hours which lead to the number of running go routine as we start multiple per open connection.
This PR updates the timeout so connections are flushed more frequently. T
Short description of the changes
FlushCloseOlderThanHow to verify that this has the expected result
Connections are now flushed and closed correctly which helps keep open go routines in check.