Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always forceflush stale data (not just based on statsevery) #99

Closed
JamieDanielson opened this issue Aug 21, 2023 · 0 comments · Fixed by #104
Closed

always forceflush stale data (not just based on statsevery) #99

JamieDanielson opened this issue Aug 21, 2023 · 0 comments · Fixed by #104

Comments

@JamieDanielson
Copy link
Contributor

JamieDanielson commented Aug 21, 2023

It seems like we should move the flush logic outside of the if block, similar to how done is outside the if block but logs based on the statsevery config option.

	flushed, closed := h.assembler.FlushCloseOlderThan(time.Now().Add(-h.config.Timeout))
	if count%h.config.Statsevery == 0 {

Originally posted by @JamieDanielson in #94 (comment)

JamieDanielson pushed a commit that referenced this issue Aug 22, 2023
## Which problem is this PR solving?
We currently flush old streams as part of packet processing when a
certain number of packets have been processed. This PR moves the flush
process to a separate process using a ticker interval.

- Closes #99 

## Short description of the changes
- Add new flush ticker
- Update for select to switch over each ticker and packet channel
- Remove flush processing from packet processing

## How to verify that this has the expected result
Agent should continue to run as it is - this is a maintenance
improvement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant