Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement base distro class #10

Closed
Tracked by #3
emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #22
Closed
Tracked by #3

implement base distro class #10

emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #22
Assignees
@MikeGoldsmith @emilyashley
Milestone
Beta

Comments

@emilyashley
Copy link
Contributor

No description provided.

@emilyashley emilyashley mentioned this issue Dec 1, 2022
Closed
33 tasks
@emilyashley emilyashley changed the title implement base diistro class implement base distro class Dec 1, 2022
@emilyashley emilyashley mentioned this issue Dec 2, 2022
Merged
@MikeGoldsmith MikeGoldsmith added this to the Beta milestone Dec 5, 2022
emilyashley added a commit that referenced this issue Dec 5, 2022
@emilyashley @MikeGoldsmith
feat: Use OTel distro class to configure SDK - allow both programatic…
845508c 
… and auto-configure hooks (#22)

## Which problem is this PR solving?
Updates the distro to introduce a the HoneycombDistro class which
introduces the hook for auto configuration via BaseDistro. Also exposes
the `configure_opentelemetry` function that can be used programatically
to configure the SDK.

- Closes #10 

## Short description of the changes
- Adds new HoneycombDistro class that depends on BaseDistro
- Adds `configure_opentelemetry` function that sets up the OTel SDK via
environment variables
- Adds unit tests for the distro to verify API key, endpoint and service
name can be set via parameter or env var

NOTE: env vars are used over parameters

Co-authored-by: Mike Goldsmth <goldsmith.mike@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeGoldsmith MikeGoldsmith

@emilyashley emilyashley

Labels
None yet
Projects
None yet
Milestone
Beta
2 participants
@MikeGoldsmith @emilyashley