feat: Use OTel distro class to configure SDK - allow both programatic and auto-configure hooks #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration Co-authored-by: Mike Goldsmth <goldsmith.mike@gmail.com>
## Which problem is this PR solving? Updates the module to not include the `-python` suffix in the module name and updates project structure to follow poetry defaults which improves import paths. For example, `import honeycomb.opentelemetry` vs `import src.honeycomb.opentelemetry` ## Short description of the changes - Rename module in pyproject.toml - Move honeycomb dir from src to root - Update flask app to use new import paths NOTE: This is a PR into #22 not main
MikeGoldsmith
changed the title
MikeGoldsmith
changed the title
emilyashley
added a commit
that referenced
this pull request
Dec 5, 2022
## Which problem is this PR solving? Adds basic Honeycomb options class that can detect and use env vars and passed in parameters ## Short description of the changes - Add HoneycombOptions class - Add unit tests to verify parameters can be set with env var and parameters NOTE: This is based on the branch from #22 - it will automatically rebase when that PR is merged Co-authored-by: Emily Ashley <15912063+emilyashley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates the distro to introduce a the HoneycombDistro class which introduces the hook for auto configuration via BaseDistro. Also exposes the
configure_opentelemetryfunction that can be used programatically to configure the SDK.Short description of the changes
configure_opentelemetryfunction that sets up the OTel SDK via environment variablesNOTE: env vars are used over parameters