Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add baggage span processor #16

Closed
2 tasks
Tracked by #3
emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #62
Closed
2 tasks
Tracked by #3

Add baggage span processor #16

emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #62
Assignees
@emilyashley
Milestone
Beta

Comments

@emilyashley
Copy link
Contributor

emilyashley commented Dec 1, 2022 •
edited by MikeGoldsmith

Create a new span processor that sets all currently set attrbutes from trace context baggage on newly started spans. This span procesor should also be added to the tracer provider.

  • Create new baggage span processor
  • Add processor to tracer provider
@emilyashley emilyashley mentioned this issue Dec 1, 2022
Closed
33 tasks
@MikeGoldsmith MikeGoldsmith added this to the Beta milestone Dec 5, 2022
@MikeGoldsmith MikeGoldsmith changed the title baggage span processor Add baggage span processor Dec 12, 2022
@emilyashley emilyashley mentioned this issue Jan 31, 2023
Merged
emilyashley added a commit that referenced this issue Feb 1, 2023
@emilyashley @JamieDanielson @pkanal
feat: baggage processor (#62)
d4fbcc0 
<!--
Thank you for contributing to the project! 💜
Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->

## Which problem is this PR solving?

- Builds out #16
(still to do, testing / smoke testing on baggage)

## Short description of the changes
- Adds examples of two ways to implement baggage in the
hello-world-flask example app
- Update trace exporter tests to include batch, baggage, console, and
local vis exporters.
- Implements a BaggageSpanProcessor that reads entries stored in Baggage
form the parent contrext and adds the baggage entries to the span on
span start. Appears on subsequent child spans.

## How to verify that this has the expected result
Run the example hello-world-flask application. 

For `curl localhost:5000`
Expect `"queen": "bee"` attribute on the `honey` span. Expect ` "queen":
"bee", "honey": "bee"` on the `child` span.

For `curl localhost:5000/ctx`
Expect `"worker": "bees"` attribute on the `bumble` span. Expect `
"worker": "bees", "bumble": "bees", "additional": "bees"` on the `last`
span.

---------

Co-authored-by: JamieDanielson <jamieedanielson@gmail.com>
Co-authored-by: Emily Ashley <emilyashley@users.noreply.github.com>
Co-authored-by: Purvi Kanal <8810222+pkanal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilyashley emilyashley

Labels
None yet
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

feat: baggage processor honeycombio/honeycomb-opentelemetry-python
3 participants
@MikeGoldsmith @emilyashley @JamieDanielson