feat: baggage processor #62

emilyashley · 2023-01-27T21:26:26Z

Which problem is this PR solving?

closes Add baggage span processor #16

Short description of the changes

Adds examples of two ways to implement baggage in the hello-world-flask example app
Update trace exporter tests to include batch, baggage, console, and local vis exporters.
Implements a BaggageSpanProcessor that reads entries stored in Baggage form the parent contrext and adds the baggage entries to the span on span start. Appears on subsequent child spans.

How to verify that this has the expected result

Run the example hello-world-flask application.

For curl localhost:5000
Expect "queen": "bee" attribute on the honey span. Expect "queen": "bee", "honey": "bee" on the child span.

For curl localhost:5000/ctx
Expect "worker": "bees" attribute on the bumble span. Expect "worker": "bees", "bumble": "bees", "additional": "bees" on the last span.

used: https://opentelemetry.io/docs/instrumentation/python/cookbook/#capturing-baggage-at-different-contexts

…n of the trace

… for shutdown

…xporters for shutdown" This reverts commit bd7df8a.

used: https://opentelemetry.io/docs/instrumentation/python/cookbook/#capturing-baggage-at-different-contexts

…n of the trace

… for shutdown

…xporters for shutdown" This reverts commit bd7df8a.

…bio/honeycomb-opentelemetry-python into emash-baggage-processor

src/honeycomb/opentelemetry/baggage.py

tests/test_baggage.py

Co-authored-by: Emily Ashley <emilyashley@users.noreply.github.com>

JamieDanielson

This is looking great! Couple more suggestions noted and then I think we'll be good to go with this.

src/honeycomb/opentelemetry/baggage.py

tests/test_baggage.py

tests/test_trace.py

tests/test_baggage.py

Co-Authored-By: Purvi Kanal <8810222+pkanal@users.noreply.github.com>

Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>

Co-Authored-By: Purvi Kanal <8810222+pkanal@users.noreply.github.com>

…bio/honeycomb-opentelemetry-python into emash-baggage-processor

pkanal

Looks great! Reviewed and addressed comments over zoom together!

JamieDanielson

emilyashley added 30 commits January 19, 2023 18:19

Start with the BatchWithBaggageSpanProcessor

a702361

Initialize the simplespanprocessor and on_start calls

c8342d8

stash

b45c1bd

Add baggage to example app

143b575

used: https://opentelemetry.io/docs/instrumentation/python/cookbook/#capturing-baggage-at-different-contexts

playing with propagation

0f9b03d

This is one way to do all three attribute additions into the last spa…

c914bfe

…n of the trace

Attach and detach tokens in example app

2cf6e68

Codestyle

7b5f8cc

wip: baggage span processor

e95a6ad

Add back in combination batch with baggage, processors NEED exporters…

bd7df8a

… for shutdown

Revert "Add back in combination batch with baggage, processors NEED e…

1fe32b7

…xporters for shutdown" This reverts commit bd7df8a.

Begin addressing tests on the order of the processors

1db2c50

Updating trace exporter tests to not rely on index of processors.

c900f63

Update distro default tests to not rely on index of span processors

acddb7f

rename test right quick

b50126d

fix import to match updated baggage class.

fedab45

Start with the BatchWithBaggageSpanProcessor

8f813e6

Initialize the simplespanprocessor and on_start calls

4e21929

stash

832b0e2

Add baggage to example app

f304227

used: https://opentelemetry.io/docs/instrumentation/python/cookbook/#capturing-baggage-at-different-contexts

playing with propagation

7cdff91

This is one way to do all three attribute additions into the last spa…

c6a9d78

…n of the trace

Attach and detach tokens in example app

90622ec

Codestyle

e3a9d90

wip: baggage span processor

ff41270

Add back in combination batch with baggage, processors NEED exporters…

2da1b4b

… for shutdown

Revert "Add back in combination batch with baggage, processors NEED e…

0077625

…xporters for shutdown" This reverts commit bd7df8a.

Begin addressing tests on the order of the processors

4d877b9

Updating trace exporter tests to not rely on index of processors.

e077ff3

Update distro default tests to not rely on index of span processors

607384d

emilyashley added 4 commits January 31, 2023 12:03

rename test right quick

fd4f415

fix import to match updated baggage class.

adace57

Merge branch 'emash-baggage-processor' of https://github.com/honeycom…

444f807

…bio/honeycomb-opentelemetry-python into emash-baggage-processor

Remove todo!

67eb660

emilyashley marked this pull request as ready for review January 31, 2023 18:18

emilyashley requested a review from a team January 31, 2023 18:18

JamieDanielson reviewed Jan 31, 2023

View reviewed changes

src/honeycomb/opentelemetry/baggage.py Outdated Show resolved Hide resolved

JamieDanielson reviewed Jan 31, 2023

View reviewed changes

src/honeycomb/opentelemetry/baggage.py Outdated Show resolved Hide resolved

src/honeycomb/opentelemetry/baggage.py Outdated Show resolved Hide resolved

JamieDanielson reviewed Jan 31, 2023

View reviewed changes

tests/test_baggage.py Show resolved Hide resolved

JamieDanielson and others added 3 commits January 31, 2023 17:40

baggage testing

c1e828f

update test to test attributes have baggage

e096e8d

Co-authored-by: Emily Ashley <emilyashley@users.noreply.github.com>

Test span attributes in token baggage.

37742ca

JamieDanielson reviewed Feb 1, 2023

View reviewed changes

emilyashley and others added 7 commits February 1, 2023 15:36

Alias get_all as get_all_baggage, rename "stuff"

4a11b63

Co-Authored-By: Purvi Kanal <8810222+pkanal@users.noreply.github.com>

Whitespace formatting

789a2e8

Co-Authored-By: Purvi Kanal <8810222+pkanal@users.noreply.github.com>

Additional test comments for baggage tokens

f1a5bdb

Co-Authored-By: Purvi Kanal <8810222+pkanal@users.noreply.github.com>

Update tests/test_trace.py

cadded7

Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>

Don't dunder.

609a841

Co-Authored-By: Purvi Kanal <8810222+pkanal@users.noreply.github.com>

Merge branch 'emash-baggage-processor' of https://github.com/honeycom…

27f5c82

…bio/honeycomb-opentelemetry-python into emash-baggage-processor

Merge branch 'main' into emash-baggage-processor

b29f610

pkanal approved these changes Feb 1, 2023

View reviewed changes

JamieDanielson approved these changes Feb 1, 2023

View reviewed changes

emilyashley merged commit d4fbcc0 into main Feb 1, 2023

emilyashley deleted the emash-baggage-processor branch February 1, 2023 22:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: baggage processor #62

feat: baggage processor #62

emilyashley commented Jan 27, 2023 •

edited by JamieDanielson

Loading

JamieDanielson left a comment

pkanal left a comment

JamieDanielson left a comment

feat: baggage processor #62

feat: baggage processor #62

Conversation

emilyashley commented Jan 27, 2023 • edited by JamieDanielson Loading

Which problem is this PR solving?

Short description of the changes

How to verify that this has the expected result

JamieDanielson left a comment

Choose a reason for hiding this comment

pkanal left a comment

Choose a reason for hiding this comment

JamieDanielson left a comment

Choose a reason for hiding this comment

emilyashley commented Jan 27, 2023 •

edited by JamieDanielson

Loading