Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade supported version of OpenTelemetry SDK #167

Closed
estraph opened this issue Dec 18, 2023 · 5 comments · Fixed by #168
Closed

Upgrade supported version of OpenTelemetry SDK #167

estraph opened this issue Dec 18, 2023 · 5 comments · Fixed by #168
Labels
type: enhancement New feature or request

Comments

@estraph
Copy link

estraph commented Dec 18, 2023

This project has a dependency constraint on the opentelemetry SDK version 1.20 aka 0.41b0

honeycomb-opentelemetry-python/pyproject.toml

Lines 11 to 14 in 5f932a6

opentelemetry-api = "1.20.0"
opentelemetry-sdk = "1.20.0"
opentelemetry-exporter-otlp = "1.20.0"
opentelemetry-instrumentation = "0.41b0"

At the time of writing there have been two releases of the opentelemetry SDK since:

Can you please release an updated version of this library with support for the latest version of opentelemetry?
@estraph estraph added the type: enhancement New feature or request label Dec 18, 2023
@JamieDanielson JamieDanielson added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Dec 20, 2023
@JamieDanielson JamieDanielson removed the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Jan 2, 2024
@estraph
Copy link
Author

estraph commented Jan 17, 2024

Hi Honeycomb team 🌈 any news on this? This constraint makes it impossible for us to use newer versions of the python OTel library. Considering Honeycomb's dedication to opentelemetry I would expect more interest in staying up to date. Let me know if there's anything I can do to help.

@JamieDanielson JamieDanielson mentioned this issue Jan 17, 2024
Merged
JamieDanielson added a commit that referenced this issue Jan 17, 2024
@JamieDanielson
maint(deps): update otel to 1.22 and 0.43b0 (#168)
67539f6 
## Which problem is this PR solving?

- update otel dependencies
- Closes #167 

## Short description of the changes

- update opentelemetry-api from "1.20.0" to "1.22.0"
- update opentelemetry-sdk from "1.20.0" to "1.22.0"
- update opentelemetry-exporter-otlp from "1.20.0" to "1.22.0"
- update opentelemetry-instrumentation from "0.41b0" to "0.43b0"
- update example deps to match, and also
opentelemetry-instrumentation-flask = "^0.43b0"
- update test for new required field "name" for ReadableSpan
- add specific version of Werkzeug to match flask in example app (see
[Stack Overflow question
here](https://stackoverflow.com/questions/77213053/why-did-flask-start-failing-with-importerror-cannot-import-name-url-quote-fr)
tldr; flask specifies >2.2 which now brings in Werkzeug 3)
@estraph
Copy link
Author

estraph commented Jan 17, 2024

Thank you @JamieDanielson!

@JamieDanielson
Copy link
Contributor

The new version should be available tomorrow @estraph , will ping back here once it's released!

@JamieDanielson
Copy link
Contributor

Hey @estraph new version v0.2.4b0 is out! Thanks for the poke.

@estraph
Copy link
Author

estraph commented Jan 18, 2024

Amazing, thank you 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

maint(deps): update otel to 1.22 and 0.43b0 honeycombio/honeycomb-opentelemetry-python
2 participants
@estraph @JamieDanielson