generated from honeycombio/.github
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerize the example flask app #72
Milestone
Comments
Closed
pushed a wip branch for this but stepping away from it for a bit in case anyone wants to pick this up in the meantime |
I pushed up some more code to make the poetry stuff work, still getting an error on an install thing so leaving it in up for grabs while I'm goalie |
JamieDanielson
changed the title
dockerize the example app
dockerize the example flask app
Feb 23, 2023
I just pushed a branch and PR hoping to address some of the build errors. |
emilyashley
added a commit
that referenced
this issue
Feb 27, 2023
<!-- Thank you for contributing to the project! 💜 Please see our [OSS process document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#) to get an idea of how we operate. --> ## Which problem is this PR solving? - Touches #72 ## Short description of the changes - Get around alpine g++ issue with grpcio wheel build failing by declaring python version and adding `build-base` to alpine. - Update opentelemetry dependencies for use together in docker smoke tests. - Run opentelemetry flask app with poetry and auto-instrumentation and specify different ports for grpc and http test apps. ## How to verify that this has the expected result from smoke-tests, `docker-compose build` and `docker-compose up` should get the two test flask apps running ✨ Note: this is for merging into Jamie's docker branch, not main.
JamieDanielson
added a commit
that referenced
this issue
Mar 1, 2023
## Which problem is this PR solving? - Closes #72 ## Short description of the changes - add Dockerfile for flask app - update `opentelemetry-api`, `opentelemetry-sdk`, and `opentelemetry-exporter-otlp` from `1.14.0` to `1.16.0` to help deal with version conflicts - update `opentelemetry-instrumentation` and `opentelemetry-instrumentation-flask` from `0.36b0` to `0.37b0` to help deal with version conflicts - update `pylint` - add flask app to docker-compose - whitespace cleanup ## How to verify that this has the expected result Build the flask app, and locally `curl localhost:5000`: `cd smoke-tests && docker-compose up --build app-sdk-grpc-flask` --------- Co-authored-by: Robb Kidd <robbkidd@honeycomb.io> Co-authored-by: Emily Ashley <15912063+emilyashley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a dockerized version of the plain python app, but this ticket is to dockerize the flask app to test more instrumentation and baggage with smoke tests
The text was updated successfully, but these errors were encountered: