Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerize the example flask app #72

Closed
Tracked by #3
emilyashley opened this issue Feb 1, 2023 · 3 comments · Fixed by #83
Closed
Tracked by #3

dockerize the example flask app #72

emilyashley opened this issue Feb 1, 2023 · 3 comments · Fixed by #83
Assignees
Milestone

Comments

@emilyashley
Copy link
Contributor

emilyashley commented Feb 1, 2023

We have a dockerized version of the plain python app, but this ticket is to dockerize the flask app to test more instrumentation and baggage with smoke tests

@vreynolds vreynolds added this to the Beta milestone Feb 1, 2023
@JamieDanielson JamieDanielson self-assigned this Feb 2, 2023
@JamieDanielson JamieDanielson removed their assignment Feb 14, 2023
@JamieDanielson
Copy link
Contributor

pushed a wip branch for this but stepping away from it for a bit in case anyone wants to pick this up in the meantime

@pkanal pkanal assigned pkanal and unassigned pkanal Feb 16, 2023
@pkanal
Copy link
Contributor

pkanal commented Feb 22, 2023

I pushed up some more code to make the poetry stuff work, still getting an error on an install thing so leaving it in up for grabs while I'm goalie

@robbkidd robbkidd assigned robbkidd and unassigned robbkidd Feb 23, 2023
@JamieDanielson JamieDanielson changed the title dockerize the example app dockerize the example flask app Feb 23, 2023
@emilyashley
Copy link
Contributor Author

I just pushed a branch and PR hoping to address some of the build errors.

@emilyashley emilyashley self-assigned this Feb 26, 2023
emilyashley added a commit that referenced this issue Feb 27, 2023
<!--
Thank you for contributing to the project! 💜
Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->

## Which problem is this PR solving?

- Touches #72 

## Short description of the changes
- Get around alpine g++ issue with grpcio wheel build failing by
declaring python version and adding `build-base` to alpine.
- Update opentelemetry dependencies for use together in docker smoke
tests.
- Run opentelemetry flask app with poetry and auto-instrumentation and
specify different ports for grpc and http test apps.

## How to verify that this has the expected result
from smoke-tests, `docker-compose build` and `docker-compose up` should
get the two test flask apps running ✨

Note: this is for merging into Jamie's docker branch, not main.
JamieDanielson added a commit that referenced this issue Mar 1, 2023
## Which problem is this PR solving?

- Closes #72 

## Short description of the changes

- add Dockerfile for flask app
- update `opentelemetry-api`, `opentelemetry-sdk`, and
`opentelemetry-exporter-otlp` from `1.14.0` to `1.16.0` to help deal
with version conflicts
- update `opentelemetry-instrumentation` and
`opentelemetry-instrumentation-flask` from `0.36b0` to `0.37b0` to help
deal with version conflicts
- update `pylint`
- add flask app to docker-compose
- whitespace cleanup

## How to verify that this has the expected result

Build the flask app, and locally `curl localhost:5000`:

`cd smoke-tests && docker-compose up --build app-sdk-grpc-flask`

---------

Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
Co-authored-by: Emily Ashley <15912063+emilyashley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants