Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: further work on dockerizing the flask app. #94

Merged

Conversation

emilyashley
Copy link
Contributor

@emilyashley emilyashley commented Feb 26, 2023

Which problem is this PR solving?

Short description of the changes

  • Get around alpine g++ issue with grpcio wheel build failing by declaring python version and adding build-base to alpine.
  • Update opentelemetry dependencies for use together in docker smoke tests.
  • Run opentelemetry flask app with poetry and auto-instrumentation and specify different ports for grpc and http test apps.

How to verify that this has the expected result

from smoke-tests, docker-compose build and docker-compose up should get the two test flask apps running ✨

Note: this is for merging into Jamie's docker branch, not main.

@emilyashley emilyashley requested a review from a team February 26, 2023 00:30
@emilyashley emilyashley self-assigned this Feb 26, 2023
@emilyashley emilyashley added this to the Beta milestone Feb 26, 2023
@emilyashley emilyashley removed this from the Beta milestone Feb 26, 2023
@emilyashley emilyashley merged commit 0bc804b into jamie.dockerize-flask Feb 27, 2023
@emilyashley emilyashley deleted the emash-dockerize-flask-branch-off-branch branch February 27, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants