Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev/user] audit of example app as an illustrative example of use #78

Closed
4 tasks
Tracked by #3
emilyashley opened this issue Feb 1, 2023 · 1 comment · Fixed by #86
Closed
4 tasks
Tracked by #3

[dev/user] audit of example app as an illustrative example of use #78

emilyashley opened this issue Feb 1, 2023 · 1 comment · Fixed by #86
Assignees
@pkanal
Milestone
Beta

Comments

@emilyashley
Copy link
Contributor

emilyashley commented Feb 1, 2023 •
edited
Loading

  • explain the differences in examples (in the main readme? and also in example readmes)

  • flask --- uses environment variable options and opentelemetry-instrument

    • has the baggage examples for context vs token

  • hello-world --- uses configure_opentelemetry and options parameters

  • Add an example of local exporter.

  • Use MOAR options

  • Metrics?

Please move the example info from developing.md to readme.md
@emilyashley emilyashley mentioned this issue Feb 1, 2023
Closed
33 tasks
@vreynolds vreynolds added this to the Beta milestone Feb 1, 2023
@pkanal pkanal self-assigned this Feb 13, 2023
@emilyashley
Copy link
Contributor Author

also, it looks like #57 is tied to this!

@robbkidd robbkidd mentioned this issue Feb 14, 2023
Closed
4 tasks
@pkanal pkanal mentioned this issue Feb 15, 2023
Merged
pkanal added a commit that referenced this issue Feb 16, 2023
@pkanal @JamieDanielson
docs: Update example apps (#86)
3c91a7c 
## Which problem is this PR solving?

- Closes #78 

## Short description of the changes
- Added metrics example
- Added local visualizations to flask example
- Added all options available with descriptions to basic example
- Reorganized readmes a bit and added some more details to example
READMEs

## How to verify that this has the expected result
- Configure a metrics dataset and run the flask app, verify that you see
metrics in Honeycomb
- Run basic app and click on local vis link

---------

Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkanal pkanal

Labels
None yet
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

docs: Update example apps honeycombio/honeycomb-opentelemetry-python
3 participants
@vreynolds @pkanal @emilyashley