docs: Update example apps #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanal
added
the
version: no bump
Comment on lines
+11
to
+20
| # traces_apikey = None, Set a specific Honeycomb API key just for traces | ||
| # metrics_apikey = None, Set a specific Honeycomb API key just for metrics | ||
| # service_version = None, Set a version for this service, will show up as an attribute on all spans | ||
| # traces_endpoint = None, Set a specific exporter endpoint just for traces | ||
| # metrics_endpoint = None, Set a specific exporter endpoint just for metrics | ||
| # exporter_protocol = "grpc", Set the exporter protocol, grpc or http/protobuf | ||
| # traces_exporter_protocol = "grpc", Set a specific exporter protocol just for traces, grpc or http/protobuf | ||
| # metrics_exporter_protocol = "grpc", Set a specific exporter protocol just for metrics, grpc or http/protobuf | ||
| # sample_rate = DEFAULT_SAMPLE_RATE, Set a sample rate for spans | ||
| # metrics_dataset = None, Set a metrics dataset to enable metrics |
JamieDanielson
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
This is great; I especially like the commented out options in the example app.
As part of this cleanup, can we also do a couple more formatting adjustments? I suggested a few things here that are either squigglies or just trying to auto-format in my editor, and this seems like the right moment to hit it.
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
…ycomb-opentelemetry-python into purvi/example-app-audit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
How to verify that this has the expected result