Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HONEYCOMB_API_ENDPOINT as an Option parsed as an environment variable. #98

Closed
Tracked by #3
emilyashley opened this issue Feb 28, 2023 · 0 comments · Fixed by #99
Closed
Tracked by #3

Add HONEYCOMB_API_ENDPOINT as an Option parsed as an environment variable. #98

emilyashley opened this issue Feb 28, 2023 · 0 comments · Fixed by #99
Assignees
@emilyashley
Milestone
Beta

Comments

@emilyashley
Copy link
Contributor

We noticed in setting up the smoke tests that setting a HONEYCOMB_API_ENDPOINT isn't picked up from the opentelemetry-instrument command that parses that distro options. #91 (comment)

Setting this as an environment variable should overwrite the DEFAULT_API_ENDPOINT.
@emilyashley emilyashley added this to the Beta milestone Feb 28, 2023
This was referenced Feb 28, 2023
Closed
Merged
@emilyashley emilyashley self-assigned this Feb 28, 2023
@emilyashley emilyashley mentioned this issue Feb 28, 2023
Merged
emilyashley added a commit that referenced this issue Mar 1, 2023
@emilyashley
feat: allow HONEYCOMB_API_ENDPOINT as an Option parsed as an environm…
6e23ae2 
…ent variable (#99)

<!--
Thank you for contributing to the project! 💜
Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->

## Which problem is this PR solving?

- Closes #98 

## Short description of the changes
Parses HONEYCOMB_API_ENDPOINT as an option. 

## How to verify that this has the expected result
In the hello-world-flask app, try something like `DEBUG=TRUE
HONEYCOMB_API_ENDPOINT=http://collector:4317
OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf
OTEL_EXPORTER_OTLP_METRICS_ENDPOINT=http://custom.metrics:666 poetry run
opentelemetry-instrument flask run` to see the expected endpoint
resolution:

```
'traces_exporter_protocol': 'http/protobuf', 
'metrics_exporter_protocol': 'http/protobuf',
 'endpoint': 'http://collector:4317', 
'traces_endpoint': 'http://collector:4317/v1/traces', 
'metrics_endpoint': 'http://custom.metrics:666', 
// not expected to append /v1/metrics for http protocol w/ specifically declared OTEL_EXPORTER_OTLP_METRICS_ENDPOINT
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilyashley emilyashley

Labels
None yet
Projects
None yet
Milestone
Beta
1 participant
@emilyashley