maint: Add Django example #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
the
type: maintenance
cartermp
approved these changes
Feb 14, 2024
robbkidd
reviewed
Feb 14, 2024
| ## Distro Instrumentation Example | ||
|
|
||
| This app uses configuration configures the OpenTelemetry SDK programmatically in [manage.py](./manage.py). | ||
| Alternitively, you can use environment variables as parameters like below: |
There was a problem hiding this comment.
Suggested change
| Alternitively, you can use environment variables as parameters like below: | |
| Alternatively, you can use environment variables as parameters like below: |
| To send to Honeycomb, set your API Key: | ||
|
|
||
| ```bash | ||
| HONEYCOMB_API_KEY="your-api-key" poetry run python3 app.py |
There was a problem hiding this comment.
Update this example command to use the same as earlier in this README for the django app.
Suggested change
| HONEYCOMB_API_KEY="your-api-key" poetry run python3 app.py | |
| HONEYCOMB_API_KEY="your-api-key" poetry run python manage.py runserver |
MikeGoldsmith
added a commit
that referenced
this pull request
Feb 15, 2024
## Which problem is this PR solving? Fixes a couple of typos in the Django example added in the following PR: - #176 ## Short description of the changes - Fix typos - Update run command to match previous example ## How to verify that this has the expected result Django example doesn't contain typos and commands execute as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds a Django example for users of that ecosystem to reference.
Short description of the changes
How to verify that this has the expected result
Some can use the django example to better understand and use this distro.