Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix django example typos #178

Merged
merged 2 commits into from
Feb 15, 2024
Merged

docs: Fix django example typos #178

merged 2 commits into from
Feb 15, 2024

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Feb 15, 2024 •
edited

Which problem is this PR solving?

Fixes a couple of typos in the Django example added in the following PR:

Short description of the changes

  • Fix typos
  • Update run command to match previous example

How to verify that this has the expected result

Django example doesn't contain typos and commands execute as expected.

@MikeGoldsmith MikeGoldsmith added type: documentation Improvements or additions to documentation version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Feb 15, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Feb 15, 2024
@MikeGoldsmith MikeGoldsmith requested a review from a team as a code owner February 15, 2024 11:16
@MikeGoldsmith MikeGoldsmith changed the title docs: Fix django docs typos docs: Fix django example typos Feb 15, 2024
kentquirk
kentquirk approved these changes Feb 15, 2024
View reviewed changes
Copy link

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're in there, could you make line 40 make sense? It's awkward at best.

@MikeGoldsmith MikeGoldsmith merged commit 6a31d89 into main Feb 15, 2024
3 checks passed
@MikeGoldsmith MikeGoldsmith deleted the mike/fix-example-docs branch February 15, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: documentation Improvements or additions to documentation version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeGoldsmith @kentquirk