Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add honeycomb resource #26

Merged
merged 4 commits into from
Dec 5, 2022
Merged

feat: Add honeycomb resource #26

merged 4 commits into from
Dec 5, 2022

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Dec 5, 2022

Which problem is this PR solving?

Adds a function to create a Honeycomb resource with distro version, python runtime, etc.

Short description of the changes

  • Adds create_resource function that returns a new Resource with Honeycomb specific attributes
  • Adds version file with basic, manual version field
  • Adds unit tests to verify resource is created as expected

NOTE: This is based on the branch from #22 - it will automatically rebase when that PR is merged

emilyashley and others added 4 commits December 1, 2022 20:04
…uration

Co-authored-by: Mike Goldsmth <goldsmith.mike@gmail.com>
## Which problem is this PR solving?

Updates the module to not include the `-python` suffix in the module
name and updates project structure to follow poetry defaults which
improves import paths.

For example, `import honeycomb.opentelemetry` vs `import
src.honeycomb.opentelemetry`

## Short description of the changes
- Rename module in pyproject.toml
- Move honeycomb dir from src to root
- Update flask app to use new import paths

NOTE: This is a PR into #22 not main
@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Dec 5, 2022
@MikeGoldsmith MikeGoldsmith requested a review from a team December 5, 2022 16:11
@MikeGoldsmith MikeGoldsmith self-assigned this Dec 5, 2022
Base automatically changed from emash-base-distro to main December 5, 2022 18:26
Copy link
Contributor

@emilyashley emilyashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️✨

@emilyashley emilyashley merged commit 7c2b196 into main Dec 5, 2022
@emilyashley emilyashley deleted the mike/resource branch December 5, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add honeycomb resorce (yay telemetry about telemetry)
2 participants