feat: Configure logging #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # honeycomb/opentelemetry/distro.py
…elemetry-python into mike/configure_pipeline # Conflicts: # honeycomb/opentelemetry/distro.py # honeycomb/opentelemetry/options.py
…elemetry-python into mike/configure_pipeline
…mbio/honeycomb-opentelemetry-python into mike/configure_pipeline # Conflicts: # examples/hello-world-flask/app.py # examples/hello-world-flask/poetry.lock # examples/hello-world-flask/pyproject.toml # honeycomb/opentelemetry/distro.py
3 tasks
robbkidd
approved these changes
Dec 12, 2022
|
|
||
| def configure_opentelemetry( | ||
| options: HoneycombOptions = HoneycombOptions(), | ||
| ): | ||
| _logger.debug("🐝 Configuring OpenTelemetry using Honeycomb distro 🐝") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Setups logging when using the distro. Log level can be set either using
OTEL_LOG_LEVELenvironment variable or thelog_leveloption.Short description of the changes
configure_opentelemetryHow to verify that this has the expected result
Log entires are printed out at the configured log level.
Note: This is based on the follow PR, and will auto update once it's merged