Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug & console warnings #17

Closed
3 tasks
Tracked by #3
emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #49
Closed
3 tasks
Tracked by #3

Add debug & console warnings #17

emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #49
Assignees
@MikeGoldsmith
Milestone
Beta

Comments

@emilyashley
Copy link
Contributor

emilyashley commented Dec 1, 2022 •
edited by MikeGoldsmith

In some following scenarios, we should print warnings for the user to inform them of bad / invalid configuration:

  • No Honeycomb API key set
  • Legacy API key and no dataset us set
  • New API key and dataset is set

Note: Depoends on the following PR to merge
@emilyashley emilyashley mentioned this issue Dec 1, 2022
Closed
33 tasks
@MikeGoldsmith MikeGoldsmith added this to the Beta milestone Dec 5, 2022
@MikeGoldsmith MikeGoldsmith changed the title debug & console warnings Add debug & console warnings Dec 12, 2022
@robbkidd robbkidd mentioned this issue Dec 14, 2022
Merged
@MikeGoldsmith MikeGoldsmith self-assigned this Dec 16, 2022
@MikeGoldsmith MikeGoldsmith mentioned this issue Dec 16, 2022
Merged
MikeGoldsmith added a commit that referenced this issue Jan 9, 2023
@MikeGoldsmith
feat: Add console warnings for misconfigured options (#49)
8f6c370 
## Which problem is this PR solving?
Adds missing console warnings for misconfigured options.

- Closes #17 

## Short description of the changes
- Add warnings for missing API keys or service, dataset for non-classic
API key and no dataset for classic API key
- Ignores the `too-many-statements` lint rule in HoneycombOptions

## How to verify that this has the expected result
Warnings are printed for misconfigured options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeGoldsmith MikeGoldsmith

Labels
None yet
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

feat: Add console warnings for misconfigured options honeycombio/honeycomb-opentelemetry-python
2 participants
@MikeGoldsmith @emilyashley