Skip to content

Commit

Permalink
fix: add opentelemetry/core as a peerdependency to package.json (#136)
Browse files Browse the repository at this point in the history
Solves #127
Closes #128 

This will fix support for package managers like `pnpm` that require you
to be very explicit about your dependencies

## Which problem is this PR solving?

Closes #128 

@Aghassi contributed a fix in that PR but we merged other PRs and
created merge conflicts. This PR resolves those merge conflicts on their
behalf.

Co-authored-by: David <david.aghassi@gmail.com>
  • Loading branch information
MustafaHaddara and Aghassi committed May 1, 2024
1 parent 9c6bbfd commit b8a0130
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"typescript": "^5.3.3"
},
"dependencies": {
"@opentelemetry/core": "~1.24.0",
"@opentelemetry/api": "~1.8.0",
"@opentelemetry/exporter-trace-otlp-http": "~0.51.0",
"@opentelemetry/instrumentation": "~0.51.0",
Expand Down

0 comments on commit b8a0130

Please sign in to comment.