fix: add opentelemetry/core as a peerdependency to package.json #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves #127 This will fix support for package managers like `pnpm` that require you to be very explicit about your dependencies Co-authored-by: David <david.aghassi@gmail.com>
pkanal
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #127
Closes #128
This will fix support for package managers like
pnpmthat require you to be very explicit about your dependenciesWhich problem is this PR solving?
Closes #128
@Aghassi contributed a fix in that PR but we merged other PRs and created merge conflicts. This PR resolves those merge conflicts on their behalf.