Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't stringify objects in builder.addField #21

Merged
merged 2 commits into from
Feb 10, 2018
Merged

don't stringify objects in builder.addField #21

merged 2 commits into from
Feb 10, 2018

Conversation

toshok
Copy link
Contributor

@toshok toshok commented Feb 10, 2018

event.addField/.add already work this way, but builder.addField does it differently because.. some reason.

Add tests for both events and builders.

@ChristopherBiscardi
Copy link

LGTM

@toshok toshok merged commit 84ffd0a into master Feb 10, 2018
@toshok toshok deleted the toshok.no-stringify branch February 10, 2018 00:45
maplebed
maplebed reviewed Feb 10, 2018
View reviewed changes
Copy link
Contributor

@maplebed maplebed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yayyayyyayyyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maplebed maplebed maplebed left review comments

Assignees

@maplebed maplebed

@ChristopherBiscardi ChristopherBiscardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toshok @ChristopherBiscardi @maplebed