-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Query resource #63
Conversation
a800004
to
ac05acf
Compare
Query annotations will look like this: tyler-boyd#1 Very similar, so if you have any feedback I'll probably apply it to both. Will open 2nd PR after this one is merged so you don't see a messier diff. |
I think this looks really good! I appreciate you updating the documentation as well 👍 Accepting the query as To be honest, it's fine for me to also add the query annotation to this PR since the files won't overlap a lot. This PR looks ready to merge, I just want to take some time to test the new resource before merging it. |
Adds Query Annotations resource
Thanks! I've merged the query-annotation branch into this one so we should see both now in this PR. I suppose this way you only need to test 1 branch, even if it's double the new resources 😄 I will have another PR later for the boards changes, it should be very small however. 👍 on renaming the datasource, I think that's a good idea. |
Anything we can do to help this along? :) |
Not really, I just haven't had the energy to look into this :( I'll try to review (and possibly merge) this tomorrow! |
CI fails because GitHub Actions does not share secrets with forks, but I can confirm the checks pass. |
Sorry for really slow response, but this is great work @tyler-boyd 😃 |
Thanks @kvrhdn! Hope the new job is treating you well. There will be a final small PR to link these ones together with boards. |
Okay, that's great. Looking forward to it! |
Howdy! Do you know when this will hit the registry? |
Hi, sorry I haven't been keeping with Honeycomb and this Terraform provider since I joined Grafana Labs. I see this PR is also pending: #67 |
@kvrhdn Thanks for the great provider! I'm looking forward to the next release |
No description provided.