Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Query resource #63

Merged
merged 4 commits into from
May 24, 2021
Merged

Adds Query resource #63

merged 4 commits into from
May 24, 2021

Conversation

tyler-boyd
Copy link
Contributor

No description provided.

@tyler-boyd
Copy link
Contributor Author

Query annotations will look like this: tyler-boyd#1

Very similar, so if you have any feedback I'll probably apply it to both. Will open 2nd PR after this one is merged so you don't see a messier diff.

@kvrhdn
Copy link
Contributor

kvrhdn commented Apr 28, 2021

I think this looks really good! I appreciate you updating the documentation as well 👍

Accepting the query as query_json so we can reuse data.honeycombio_query is a good way to avoid duplicate code. Now I'm just wondering whether we should rename the honeycombio_query datasource to honeycombio_query_spec since this aligns better with the docs... 🤔 But that's whole other discussion that is not super relevant to this PR.

To be honest, it's fine for me to also add the query annotation to this PR since the files won't overlap a lot. This PR looks ready to merge, I just want to take some time to test the new resource before merging it.

@tyler-boyd
Copy link
Contributor Author

Thanks! I've merged the query-annotation branch into this one so we should see both now in this PR. I suppose this way you only need to test 1 branch, even if it's double the new resources 😄 I will have another PR later for the boards changes, it should be very small however.

👍 on renaming the datasource, I think that's a good idea.

@grimesjm
Copy link

Anything we can do to help this along? :)

@kvrhdn
Copy link
Contributor

kvrhdn commented May 23, 2021

Not really, I just haven't had the energy to look into this :( I'll try to review (and possibly merge) this tomorrow!

@kvrhdn
Copy link
Contributor

kvrhdn commented May 24, 2021

CI fails because GitHub Actions does not share secrets with forks, but I can confirm the checks pass.

@kvrhdn kvrhdn merged commit 955fa5c into honeycombio:main May 24, 2021
@kvrhdn
Copy link
Contributor

kvrhdn commented May 24, 2021

Sorry for really slow response, but this is great work @tyler-boyd 😃

@kvrhdn kvrhdn mentioned this pull request May 24, 2021
@tyler-boyd
Copy link
Contributor Author

Thanks @kvrhdn! Hope the new job is treating you well. There will be a final small PR to link these ones together with boards.

@tyler-boyd tyler-boyd deleted the resource-queries branch May 25, 2021 15:11
@kvrhdn
Copy link
Contributor

kvrhdn commented May 25, 2021

Okay, that's great. Looking forward to it!

@clebio
Copy link

clebio commented Aug 12, 2021

Howdy! Do you know when this will hit the registry?

@kvrhdn
Copy link
Contributor

kvrhdn commented Aug 12, 2021

Hi, sorry I haven't been keeping with Honeycomb and this Terraform provider since I joined Grafana Labs. I see this PR is also pending: #67
I'll try to it merged and aim for a new release by next week.

@leonsp-ai
Copy link

@kvrhdn Thanks for the great provider! I'm looking forward to the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants