refactor(trie-router): parentPatterns is updated but never queried (#…

…2503)
honojs · Apr 13, 2024 · 7e113f3 · 7e113f3
1 parent a33b9b7
commit 7e113f3
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/deno_dist/router/trie-router/node.ts b/deno_dist/router/trie-router/node.ts
@@ -44,13 +44,11 @@ export class Node<T> {
     const parts = splitRoutingPath(path)
 
     const possibleKeys: string[] = []
-    const parentPatterns: Pattern[] = []
 
     for (let i = 0, len = parts.length; i < len; i++) {
       const p: string = parts[i]
 
       if (Object.keys(curNode.children).includes(p)) {
-        parentPatterns.push(...curNode.patterns)
         curNode = curNode.children[p]
         const pattern = getPattern(p)
         if (pattern) {
@@ -64,10 +62,8 @@ export class Node<T> {
       const pattern = getPattern(p)
       if (pattern) {
         curNode.patterns.push(pattern)
-        parentPatterns.push(...curNode.patterns)
         possibleKeys.push(pattern[1])
       }
-      parentPatterns.push(...curNode.patterns)
       curNode = curNode.children[p]
     }
 

diff --git a/src/router/trie-router/node.ts b/src/router/trie-router/node.ts
@@ -44,13 +44,11 @@ export class Node<T> {
     const parts = splitRoutingPath(path)
 
     const possibleKeys: string[] = []
-    const parentPatterns: Pattern[] = []
 
     for (let i = 0, len = parts.length; i < len; i++) {
       const p: string = parts[i]
 
       if (Object.keys(curNode.children).includes(p)) {
-        parentPatterns.push(...curNode.patterns)
         curNode = curNode.children[p]
         const pattern = getPattern(p)
         if (pattern) {
@@ -64,10 +62,8 @@ export class Node<T> {
       const pattern = getPattern(p)
       if (pattern) {
         curNode.patterns.push(pattern)
-        parentPatterns.push(...curNode.patterns)
         possibleKeys.push(pattern[1])
       }
-      parentPatterns.push(...curNode.patterns)
       curNode = curNode.children[p]
     }